git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 2/3] git-gui: fix PATH environment for mingw development environment

From
Heiko Voigt <hvoigt@hvoigt.net>
Date
Feb 27, 2010, 20:47 UTC
Message-ID
<20100227204741.GC33000@book.hvoigt.net>
In-Reply-To
<20100227204549.GB33000@book.hvoigt.net>

When creating a desktop shortcut from the gui the shortcut directly starts wish with the git-gui script. In the msysgit development environment some dll's reside in the mingw/bin directory which causes that git can not start because libiconv2.dll is not found.

When using such a link the error is even more cryptic stating: "child killed: unknown signal"

Signed-off-by: Heiko Voigt <hvoigt@hvoigt.net>
---
I am not sure whether this is the most elegant solution, but making this
work would definitely ease the development workflow.
 git-gui/windows/git-gui.sh |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/git-gui/windows/git-gui.sh b/git-gui/windows/git-gui.sh
index 66bbb2f..b1845c5 100644
--- a/git-gui/windows/git-gui.sh
+++ b/git-gui/windows/git-gui.sh
@@ -13,10 +13,11 @@ if { $argc >=2 && [lindex $argv 0] == "--working-dir" } {
 	incr argc -2
 }
 
-set bindir [file dirname \
+set basedir [file dirname \
             [file dirname \
              [file dirname [info script]]]]
-set bindir [file join $bindir bin]
+set bindir [file join $basedir bin]
+set bindir "$bindir;[file join $basedir mingw bin]"
 regsub -all ";" $bindir "\\;" bindir
 set env(PATH) "$bindir;$env(PATH)"
 unset bindir
-- 
1.7.0.m5.rc3.5.g38df2
Previous: Heiko VoigtNext: Pat Thoyts
Message 7 of 12 in “git gui create desktop icon currently does not work”
  1. Heiko VoigtFeb 23, 2010
  2. Giuseppe BilottaFeb 23, 2010
  3. Heiko VoigtFeb 23, 2010
  4. Giuseppe BilottaFeb 25, 2010
  5. Heiko VoigtFeb 27, 2010
  6. 1/3 git-gui: fix usage of _gitworktree when creating shortcut for windowsHeiko Voigt, Feb 27, 2010
  7. 2/3 git-gui: fix PATH environment for mingw development environmentHeiko Voigt, Feb 27, 2010
  8. Pat ThoytsFeb 28, 2010
  9. Heiko VoigtFeb 28, 2010
  10. 3/3 git-gui: fix shortcut creation on cygwinHeiko Voigt, Feb 27, 2010
  11. Johannes SchindelinMar 8, 2010
  12. Giuseppe BilottaFeb 27, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.