git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 3/3] git-gui: fix shortcut creation on cygwin

From
Heiko Voigt <hvoigt@hvoigt.net>
Date
Feb 27, 2010, 20:48 UTC
Message-ID
<20100227204848.GD33000@book.hvoigt.net>
In-Reply-To
<20100227204549.GB33000@book.hvoigt.net>

When the user tried to create a desktop icon with git gui on cygwin wscript was complaining about an unknown option and displaying the non-native path as such.

Signed-off-by: Heiko Voigt <hvoigt@hvoigt.net>
---
 git-gui/lib/win32.tcl |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/git-gui/lib/win32.tcl b/git-gui/lib/win32.tcl
index d7f93d0..db91ab8 100644
--- a/git-gui/lib/win32.tcl
+++ b/git-gui/lib/win32.tcl
@@ -18,9 +18,9 @@ proc win32_create_lnk {lnk_path lnk_exec lnk_dir} {
 	eval [list exec wscript.exe \
 		/E:jscript \
 		/nologo \
-		[file join $oguilib win32_shortcut.js] \
+		[file nativename [file join $oguilib win32_shortcut.js]] \
 		$lnk_path \
-		[file join $oguilib git-gui.ico] \
+		[file nativename [file join $oguilib git-gui.ico]] \
 		$lnk_dir \
 		$lnk_exec] $lnk_args
 }
-- 
1.7.0.m5.rc3.5.g38df2
Previous: Heiko VoigtNext: Johannes Schindelin
Message 10 of 12 in “git gui create desktop icon currently does not work”
  1. Heiko VoigtFeb 23, 2010
  2. Giuseppe BilottaFeb 23, 2010
  3. Heiko VoigtFeb 23, 2010
  4. Giuseppe BilottaFeb 25, 2010
  5. Heiko VoigtFeb 27, 2010
  6. 1/3 git-gui: fix usage of _gitworktree when creating shortcut for windowsHeiko Voigt, Feb 27, 2010
  7. 2/3 git-gui: fix PATH environment for mingw development environmentHeiko Voigt, Feb 27, 2010
  8. Pat ThoytsFeb 28, 2010
  9. Heiko VoigtFeb 28, 2010
  10. 3/3 git-gui: fix shortcut creation on cygwinHeiko Voigt, Feb 27, 2010
  11. Johannes SchindelinMar 8, 2010
  12. Giuseppe BilottaFeb 27, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.