Re: [PATCH] string-list: remove print_string_list, since it is not used anymore.

From: Thiago Farina <tfransosi@gmail.com>
Date: Jan 11, 2010, 22:34 UTC
Message-ID: <a4c8a6d01001111434j18b77b88j525b9acb47c7e100@mail.gmail.com>
In-Reply-To: <alpine.LFD.2.00.1001111722150.10143@xanadu.home>

On Mon, Jan 11, 2010 at 8:23 PM, Nicolas Pitre <nico@fluxnic.net> wrote:

Show 21 quoted lines

> On Mon, 11 Jan 2010, Junio C Hamano wrote:
>
>> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>>
>> > On Mon, 11 Jan 2010, Thiago Farina wrote:
>> >
>> >> Signed-off-by: Thiago Farina <tfransosi@gmail.com>
>> >> ---
>> >
>> > It was never used, except for debugging.  Does it hurt you really all that
>> > much?
>>
>> Exactly my feeling.
>>
>> I think I discarded at least two other patches sent to me to remove this
>> "unused" (but obviously meant for debugging) function in the past.  I
>> guess we'll keep the function this time, too.
>
> If so many people are so inclined to discard it, then maybe a little
> comment could be added to explain its existance?
>

I can add the comment if Junio is ok with it. Something like this: "This functions is for debugging purpose only. Please, do NOT remove it."