From: Thiago Farina Date: Mon, 11 Jan 2010 22:34:02 GMT Subject: Re: [PATCH] string-list: remove print_string_list, since it is not used anymore. Message-ID: In-Reply-To: On Mon, Jan 11, 2010 at 8:23 PM, Nicolas Pitre wrote: > On Mon, 11 Jan 2010, Junio C Hamano wrote: > >> Johannes Schindelin writes: >> >> > On Mon, 11 Jan 2010, Thiago Farina wrote: >> > >> >> Signed-off-by: Thiago Farina >> >> --- >> > >> > It was never used, except for debugging.  Does it hurt you really all that >> > much? >> >> Exactly my feeling. >> >> I think I discarded at least two other patches sent to me to remove this >> "unused" (but obviously meant for debugging) function in the past.  I >> guess we'll keep the function this time, too. > > If so many people are so inclined to discard it, then maybe a little > comment could be added to explain its existance? > I can add the comment if Junio is ok with it. Something like this: "This functions is for debugging purpose only. Please, do NOT remove it."