threads / patch / 22175

patchstring-list: remove print_string_list, since it is not used anymore.

Subject: [PATCH] string-list: remove print_string_list, since it is not used anymore.

## tl;dr

6 messages between Jan 11, 2010 and Jan 11, 2010. Diffs are folded; open one to read it.

replies: 5people: 4as markdown or json

Thiago Farina· Jan 11, 2010, 21:29 UTC · lore
Signed-off-by: Thiago Farina <tfransosi@gmail.com>
---
 string-list.c |   10 ----------
 string-list.h |    1 -
 2 files changed, 0 insertions(+), 11 deletions(-)
Show changes to 2 files +0 −11

string-list.c, string-list.h

diff --git a/string-list.c b/string-list.c
index 1ac536e..e929745 100644
--- a/string-list.c
+++ b/string-list.c
@@ -138,16 +138,6 @@ void string_list_clear_func(struct string_list *list, string_list_clear_func_t c
 	list->nr = list->alloc = 0;
 }
 
-
-void print_string_list(const char *text, const struct string_list *p)
-{
-	int i;
-	if ( text )
-		printf("%s\n", text);
-	for (i = 0; i < p->nr; i++)
-		printf("%s:%p\n", p->items[i].string, p->items[i].util);
-}
-
 struct string_list_item *string_list_append(const char *string, struct string_list *list)
 {
 	ALLOC_GROW(list->items, list->nr + 1, list->alloc);
diff --git a/string-list.h b/string-list.h
index 6569cf6..8598257 100644
--- a/string-list.h
+++ b/string-list.h
@@ -12,7 +12,6 @@ struct string_list
 	unsigned int strdup_strings:1;
 };
 
-void print_string_list(const char *text, const struct string_list *p);
 void string_list_clear(struct string_list *list, int free_util);
 
 /* Use this function to call a custom clear function on each util pointer */

-- 
1.6.6.103.g699d2
Johannes Schindelin· Jan 11, 2010, 21:52 UTC · re: Thiago Farina · lore

Re: [PATCH] string-list: remove print_string_list, since it is not used anymore.

Hi.
On Mon, 11 Jan 2010, Thiago Farina wrote:
> Signed-off-by: Thiago Farina <tfransosi@gmail.com>
> ---

It was never used, except for debugging. Does it hurt you really all that much?

Ciao, Dscho

Junio C Hamano· Jan 11, 2010, 22:14 UTC · re: Johannes Schindelin · lore

Re: [PATCH] string-list: remove print_string_list, since it is not used anymore.

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
Show 7 quoted lines
> On Mon, 11 Jan 2010, Thiago Farina wrote:
>
>> Signed-off-by: Thiago Farina <tfransosi@gmail.com>
>> ---
>
> It was never used, except for debugging.  Does it hurt you really all that 
> much?
Exactly my feeling.

I think I discarded at least two other patches sent to me to remove this "unused" (but obviously meant for debugging) function in the past. I guess we'll keep the function this time, too.

Nicolas Pitre· Jan 11, 2010, 22:23 UTC · re: Junio C Hamano · lore

Re: [PATCH] string-list: remove print_string_list, since it is not used anymore.

On Mon, 11 Jan 2010, Junio C Hamano wrote:
Show 15 quoted lines
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
> > On Mon, 11 Jan 2010, Thiago Farina wrote:
> >
> >> Signed-off-by: Thiago Farina <tfransosi@gmail.com>
> >> ---
> >
> > It was never used, except for debugging.  Does it hurt you really all that 
> > much?
> 
> Exactly my feeling.
> 
> I think I discarded at least two other patches sent to me to remove this
> "unused" (but obviously meant for debugging) function in the past.  I
> guess we'll keep the function this time, too.

If so many people are so inclined to discard it, then maybe a little comment could be added to explain its existance?

Nicolas
Thiago Farina· Jan 11, 2010, 22:34 UTC · re: Nicolas Pitre · lore

Re: [PATCH] string-list: remove print_string_list, since it is not used anymore.

On Mon, Jan 11, 2010 at 8:23 PM, Nicolas Pitre <nico@fluxnic.net> wrote:
Show 21 quoted lines
> On Mon, 11 Jan 2010, Junio C Hamano wrote:
>
>> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>>
>> > On Mon, 11 Jan 2010, Thiago Farina wrote:
>> >
>> >> Signed-off-by: Thiago Farina <tfransosi@gmail.com>
>> >> ---
>> >
>> > It was never used, except for debugging.  Does it hurt you really all that
>> > much?
>>
>> Exactly my feeling.
>>
>> I think I discarded at least two other patches sent to me to remove this
>> "unused" (but obviously meant for debugging) function in the past.  I
>> guess we'll keep the function this time, too.
>
> If so many people are so inclined to discard it, then maybe a little
> comment could be added to explain its existance?
>

I can add the comment if Junio is ok with it. Something like this: "This functions is for debugging purpose only. Please, do NOT remove it."

Junio C Hamano· Jan 11, 2010, 22:51 UTC · re: Thiago Farina · lore

Re: [PATCH] string-list: remove print_string_list, since it is not used anymore.

Thiago Farina <tfransosi@gmail.com> writes:
> I can add the comment if Junio is ok with it. Something like this:
> "This functions is for debugging purpose only. Please, do NOT remove
> it."

Something like this should suffice, as I think "Please blah" is just superfluous.

I don't know if I like "#ifdef DEBUG" better, though. It will still let you say "call print_string_list(...)" in your debugger session, and people wouldn't muck with it even if there is no caller.

Show changes to 2 files +2 −1

string-list.c, string-list.h

diff --git a/string-list.c b/string-list.c
index 1ac536e..793e619 100644
--- a/string-list.c
+++ b/string-list.c
@@ -139,6 +139,7 @@ void string_list_clear_func(struct string_list *list, string_list_clear_func_t c
 }
 
 
+#ifndef NDEBUG
 void print_string_list(const char *text, const struct string_list *p)
 {
 	int i;
@@ -147,6 +148,7 @@ void print_string_list(const char *text, const struct string_list *p)
 	for (i = 0; i < p->nr; i++)
 		printf("%s:%p\n", p->items[i].string, p->items[i].util);
 }
+#endif
 
 struct string_list_item *string_list_append(const char *string, struct string_list *list)
 {
diff --git a/string-list.h b/string-list.h
index 6569cf6..8598257 100644
--- a/string-list.h
+++ b/string-list.h
@@ -12,7 +12,6 @@ struct string_list
 	unsigned int strdup_strings:1;
 };
 
-void print_string_list(const char *text, const struct string_list *p);
 void string_list_clear(struct string_list *list, int free_util);
 
 /* Use this function to call a custom clear function on each util pointer */

← back to recent threads