git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 3/3] t3428: restore coverage for "apply" backend

From
PWPhillip Wood <phillip.wood123@gmail.com>
Date
Apr 12, 2024, 13:53 UTC
Message-ID
<a42bd1c4-1d44-427e-ab4d-76a72b02502f@gmail.com>
In-Reply-To
<33c6c944-e1f7-48e1-a9f2-8bd5027b7c61@gmail.com>
On 12/04/2024 10:33, phillip.wood123@gmail.com wrote:
Show 15 quoted lines
> On 10/04/2024 17:45, Junio C Hamano wrote:
>> phillip.wood123@gmail.com writes:
>> Perhaps we can write that in the log message to help the next person
>> who reads the patch?  Something like...
>>
>>      t3428: restore coverage for "apply" backend
>>      This test file assumes the "apply" backend is the default which is
>>      not the case since 2ac0d6273f (rebase: change the default backend
>>      from "am" to "merge", 2020-02-15).  The way "merge" backend honors
>>      "--signoff" is already tested elsewhere, so make sure the "apply"
>>      backend is tested by specifying it explicitly.
>>      Signed-off-by: Phillip Wood <phillip.wood@dunelm.org.uk>
>>      Signed-off-by: Junio C Hamano <gitster@pobox.com>
> 
> Sounds good, I'll send a re-roll
Oh, it looks like this hit next yesterday
Phillip
Previous: phillip.wood123@gmail.com
Message 12 of 12 in “Cleanup rebase signoff tests”
  1. 0/3 Cleanup rebase signoff testsPhillip Wood via GitGitGadget, Apr 9, 2024
  2. 1/3 t3428: modernize test setupPhillip Wood via GitGitGadget, Apr 9, 2024
  3. 2/3 t3428: use test_commit_messagePhillip Wood via GitGitGadget, Apr 9, 2024
  4. Junio C HamanoApr 9, 2024
  5. 3/3 t3428: restore coverage for "apply" backendPhillip Wood via GitGitGadget, Apr 9, 2024
  6. Junio C HamanoApr 9, 2024
  7. phillip.wood123@gmail.comApr 10, 2024
  8. Junio C HamanoApr 10, 2024
  9. phillip.wood123@gmail.comApr 10, 2024
  10. Junio C HamanoApr 10, 2024
  11. phillip.wood123@gmail.comApr 12, 2024
  12. Phillip WoodApr 12, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.