git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 3/3] t3428: restore coverage for "apply" backend

From
Junio C Hamano <gitster@pobox.com>
Date
Apr 10, 2024, 14:22 UTC
Message-ID
<xmqqjzl5z4a9.fsf@gitster.g>
In-Reply-To
<6ab115bf-7b78-4633-a64c-9a0925d68e3f@gmail.com>
phillip.wood123@gmail.com writes:
Show 7 quoted lines
>> Hmph, doesn't this lose coverage for the merge backend, though?
>
> I don't think so, we had coverage for the merge backend from the other
> tests before 2ac0d6273f as all of the other tests in this file use the
> merge backend. We're no longer testing "--signoff" without specifying
> some other option that selects a backend but it seems unlikely that we
> could break that without breaking one of the other tests.

OK, so we have "rebase --merge --signoff" tested elsewhere and we are replacing "rebase --signoff" with "rebase --apply --signoff"?

Thanks.
Previous: phillip.wood123@gmail.comNext: phillip.wood123@gmail.com
Message 8 of 12 in “Cleanup rebase signoff tests”
  1. 0/3 Cleanup rebase signoff testsPhillip Wood via GitGitGadget, Apr 9, 2024
  2. 1/3 t3428: modernize test setupPhillip Wood via GitGitGadget, Apr 9, 2024
  3. 2/3 t3428: use test_commit_messagePhillip Wood via GitGitGadget, Apr 9, 2024
  4. Junio C HamanoApr 9, 2024
  5. 3/3 t3428: restore coverage for "apply" backendPhillip Wood via GitGitGadget, Apr 9, 2024
  6. Junio C HamanoApr 9, 2024
  7. phillip.wood123@gmail.comApr 10, 2024
  8. Junio C HamanoApr 10, 2024
  9. phillip.wood123@gmail.comApr 10, 2024
  10. Junio C HamanoApr 10, 2024
  11. phillip.wood123@gmail.comApr 12, 2024
  12. Phillip WoodApr 12, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.