From: Phillip Wood Date: Fri, 12 Apr 2024 13:53:51 GMT Subject: Re: [PATCH 3/3] t3428: restore coverage for "apply" backend Message-ID: In-Reply-To: <33c6c944-e1f7-48e1-a9f2-8bd5027b7c61@gmail.com> On 12/04/2024 10:33, phillip.wood123@gmail.com wrote: > On 10/04/2024 17:45, Junio C Hamano wrote: >> phillip.wood123@gmail.com writes: >> Perhaps we can write that in the log message to help the next person >> who reads the patch?  Something like... >> >>      t3428: restore coverage for "apply" backend >>      This test file assumes the "apply" backend is the default which is >>      not the case since 2ac0d6273f (rebase: change the default backend >>      from "am" to "merge", 2020-02-15).  The way "merge" backend honors >>      "--signoff" is already tested elsewhere, so make sure the "apply" >>      backend is tested by specifying it explicitly. >>      Signed-off-by: Phillip Wood >>      Signed-off-by: Junio C Hamano > > Sounds good, I'll send a re-roll Oh, it looks like this hit next yesterday Phillip