Re: [PATCH 7/7] builtin/maintenance: fix auto-detach with non-standard tasks

From: Phillip Wood <phillip.wood123@gmail.com>
Date: Aug 14, 2024, 15:13 UTC
Message-ID: <a3e9a4f9-baef-4c11-9f38-f30ff333e87a@gmail.com>
In-Reply-To: <ZrwvWIhjZuFkRNgl@tanuki>

On 14/08/2024 05:15, Patrick Steinhardt wrote:

Show 11 quoted lines

> On Tue, Aug 13, 2024 at 02:19:20PM +0100, Phillip Wood wrote:
>> On 13/08/2024 12:59, Patrick Steinhardt wrote:
>>
>> Oh, I  misunderstood what this patch is changing. So despite being tagged
>> builtin/maintenance and talking about "git maintenance" it does not actually
>> touch builtin/maintenance.c or change its behavior. What it is actually
>> doing is changing how other git commands run "git maintenance --auto" so
>> that it is always run in the background unless the user configures
>> maintenance.autoDetach=false. That sounds like a good change.
>>
>> Thanks for clarifying

Sorry my message sounds grumpier than I intended.

> Yes. I should've probably prefixed this with "run-command:", not with
> "builtin/maintenance".

That's a good idea, I think the important thing we want to convey is that we're changing the way we run "git maintenance --auto", not the behavior of "git maintenance" itself.

Thanks

Phillip

> Patrick
>