Re: [PATCH 1/3] t7900: fix flaky test due to leaking background job

From: Jeff King <peff@peff.net>
Date: Aug 19, 2024, 09:12 UTC
Message-ID: <20240819091241.GA2958552@coredump.intra.peff.net>
In-Reply-To: <ZsMIa_5jCFs4OWYx@tanuki>

On Mon, Aug 19, 2024 at 10:55:07AM +0200, Patrick Steinhardt wrote:

Show 5 quoted lines

> > This looks correct, but should we be doing it for all of the "git
> > maintenance" runs in that script? They're all going to kick off detached
> > gc jobs, I think.
> 
> Only those that use `--detach` run in the background.

I thought since the default for maintenance.autoDetach was true, all of the "--auto" ones would need something similar. I notice a lot of those use "--task", though, so maybe that doesn't count. I'm not clear on all of the rules.

-Peff

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.