Re: [PATCH v2] date: detect underflow when parsing dates with positive timezone offset

From: darcy <acednes@gmail.com>
Date: Jun 6, 2024, 04:56 UTC
Message-ID: <a3b8a245-fd88-4798-990c-a06c911ce067@gmail.com>
In-Reply-To: <xmqq1q5bti4g.fsf@gitster.g>

On 6/6/24 03:27, Junio C Hamano wrote:

Show 11 quoted lines

> Phillip Wood <phillip.wood123@gmail.com> writes:
>
>> Thanks for taking a closer look, I wasn't aware of that. Reading
>> Peff's reply it seems like timestamp is actually unsigned and as we
>> limit the maximum year to 2099 it seems unlikely we'll overflow from
>> too larger date after all.
> Thanks all.
>
> I haven't seen one question I posed answered, though.  Has
> https://git.github.io/htmldocs/SubmittingPatches.html#real-name
> been followed in this patch when signing off the patch?

I have changed the line in the commit to properly follow that rule.