Re: [PATCH v2 0/2] add-p P fixups

From: Rubén Justo <rjusto@gmail.com>
Date: Jul 24, 2024, 16:12 UTC
Message-ID: <a25c37e2-fcfd-4a4c-890b-a85039ccef12@gmail.com>
In-Reply-To: <5735bee3-0532-4894-b717-12a0bdcb9e84@gmail.com>

On Wed, Jul 24, 2024 at 04:21:53PM +0100, phillip.wood123@gmail.com wrote:

Show 7 quoted lines

> > I hope that what we already have in Junio's tree is the final iteration
> > of this long series and that we can let it settle before making further
> > changes.
> 
> The resulting tree is good, but the history is not bisectable. You should
> squash the fixups locally, updating the message of the fixed up commit as
> needed and submit the result as the final version.

That was my initial thought [*1*] when the problem with "dash 0.5.10.2-6" appeared.

Junio proposed [*2*] documenting the changes to address it as a separate patch, and I think it makes sense and it is valuable to capture the situation this way in the history.

Regarding the bisectability, I don't understand what stops from being bisectable. Except in a scenario with a shell like "dash 0.5.10.2-6" there won't be any problem. And in one with it, which should be uncommon, the situation is well explained.

So, I dunno.

   1.- 2b57479c-29c8-4a6e-b7b0-1309395cfbd9@gmail.com

   2.- xmqq7cdd9l0m.fsf@gitster.g