Re: Re* [PATCH v2 0/2] add-p P fixups

From: Rubén Justo <rjusto@gmail.com>
Date: Jul 26, 2024, 19:22 UTC
Message-ID: <1dc4cb5d-966a-402f-a880-42280750b949@gmail.com>
In-Reply-To: <xmqqsevwui31.fsf@gitster.g>

On Fri, Jul 26, 2024 at 11:24:50AM -0700, Junio C Hamano wrote:

Show 20 quoted lines

> Rubén Justo <rjusto@gmail.com> writes:
> 
> > On 7/25/24 5:24 PM, Junio C Hamano wrote:
> >> Phillip Wood <phillip.wood123@gmail.com> writes:
> >> 
> >>> ... We
> >>> can add a comment about the dash problem to the commit message when
> >>> this fixup is squashed. Also the problem is now documented in
> >>> Documentation/CodingGuidelines which is more likely to be read by
> >>> other contributors.
> >> 
> >> That is a good thing to take into consideration, indeed.
> >
> > Rubén Justo (2):
> >   pager: introduce wait_for_pager
> >   add-patch: render hunks through the pager
> 
> Hmph, what happened to the first two out of the four patch series?
> Retracted?  Or you just didn't bother sending the whole thing?
>

No, I just wanted to modify only the two commits in rj/add-p-pager that were affected by the fixups.

I thought it wasn't necessary to modify the first two, which remain correct, and I didn't want to bring them up again. Additionally, keeping the dates of the first two different from the two modified here could be interesting.

That's the reason. I didn't want to cause any distraction or add any inconvenience, if that has been the case.