Re: [PATCH v2 0/2] add-p P fixups

From: Phillip Wood <phillip.wood123@gmail.com>
Date: Jul 25, 2024, 09:45 UTC
Message-ID: <97902c27-63c9-4537-8ebe-853ef0cb1d3b@gmail.com>
In-Reply-To: <a25c37e2-fcfd-4a4c-890b-a85039ccef12@gmail.com>

Hi Rubén

On 24/07/2024 17:12, Rubén Justo wrote:

Show 8 quoted lines

> On Wed, Jul 24, 2024 at 04:21:53PM +0100, phillip.wood123@gmail.com wrote:
> 
> That was my initial thought [*1*] when the problem with "dash
> 0.5.10.2-6" appeared.
> 
> Junio proposed [*2*] documenting the changes to address it as a separate
> patch, and I think it makes sense and it is valuable to capture the
> situation this way in the history.

We normally avoid merging commits that are known to break our ci. We can add a comment about the dash problem to the commit message when this fixup is squashed. Also the problem is now documented in Documentation/CodingGuidelines which is more likely to be read by other contributors.

> Regarding the bisectability, I don't understand what stops from being
> bisectable.  Except in a scenario with a shell like "dash 0.5.10.2-6"
> there won't be any problem.

But we know that shell is in use in a popular Linux distribution so it is a problem for those users.

Best Wishes

Phillip

Show 8 quoted lines

> And in one with it, which should be
> uncommon, the situation is well explained.
> 
> So, I dunno.
> 
>     1.- 2b57479c-29c8-4a6e-b7b0-1309395cfbd9@gmail.com
> 
>     2.- xmqq7cdd9l0m.fsf@gitster.g