Re: [PATCH v2 2/3] merge: replace atoi() with strtol_i() for marker size validation
- From
Taylor Blau <me@ttaylorr.com>
- Date
- Oct 21, 2024, 19:56 UTC
- Message-ID
- <ZxayARcJ1nBKt2mh@nand.local>
- In-Reply-To
- <CAPSxiM9W+YcJqxnkFmOpBcHuHab6V_vn+ibwgq-vCNWZUXPw=w@mail.gmail.com>
On Mon, Oct 21, 2024 at 06:00:55PM +0000, Usman Akinyemi wrote:
> Hi Taylor, when I try to use this warning(_, I was getting some error > In the editor
Let's see...
Show 6 quoted lines
> erge-ll.c: In function ‘ll_merge’:
> merge-ll.c:432:33: error: implicit declaration of function ‘_’
> [-Wimplicit-function-declaration]
> 432 | warning(_("invalid marker-size '%s',
> expecting an integer"), check->items[1].value);
> | ^Your compiler is correctly indicating that the error is that the function '_' is undefined, likely because this file does not include "gettext.h", which is what defines that function.
Thanks, Taylor