Re: [PATCH 3/3] parse: replace atoi() with strtoul_ui() and strtol_i()

From: Phillip Wood <phillip.wood123@gmail.com>
Date: Oct 14, 2024, 13:48 UTC
Message-ID: <4d178731-b530-4806-84da-abda50b2ecd4@gmail.com>
In-Reply-To: <63b3f6e1-d076-4522-9dee-79516200b8c3@app.fastmail.com>

Hi Kristoffer

On 14/10/2024 11:06, Kristoffer Haugsbakk wrote:

Show 13 quoted lines

>>> Cc: gitster@pobox.com
>>> Cc: Patrick Steinhardt <ps@pks.im>
>>> Cc: phillip.wood123@gmail.com
>>> Cc: Christian Couder <christian.couder@gmail.com>
>>> Cc: Eric Sunshine <sunshine@sunshineco.com>
>>> Cc: Taylor Blau <me@ttaylorr.com>
>>
>> We do not tend to use Cc: footers on this list. Also note that as there
>> is a blank line between the Signed-off-by: line and this paragraph the
>> Signed-off-by: will be ignored by git-interpret-trailers.
> 
> I thought that gitgitgadget checked for missing sign-off.  I’ve seen
> that message before at least.

I'm not sure what the DCO check does as I can't figure out what code its running, but it looks like the commit lint just uses a regex on the whole commit message[1]. I think the check could be tightened up to ensure there is a Signed-off-by line that matches the commit author as I seem to recall we've sometimes seen SOB lines with another identity instead.

Best Wishes

Phillip

[1] https://github.com/gitgitgadget/gitgitgadget/blob/7726b025bfaa18b72c889ae01f053d77d34f199d/lib/commit-lint.ts#L142