Re: [PATCH v2 0/3] parse: replace atoi() with strtoul_ui() and strtol_i()
- From
Usman Akinyemi <usmanakinyemi202@gmail.com>
- Date
- Oct 18, 2024, 21:43 UTC
- Message-ID
- <CAPSxiM_K_=My1KnUjdBpb8k8LGQRBU_8kB6wy8mLcNdawVVTiw@mail.gmail.com>
- In-Reply-To
- <ZxLUvlN9f7QP+kdY@nand.local>
On Fri, Oct 18, 2024 at 9:36 PM Taylor Blau <me@ttaylorr.com> wrote:
Show 23 quoted lines
> > On Fri, Oct 18, 2024 at 09:29:44PM +0000, Usman Akinyemi wrote: > > On Fri, Oct 18, 2024 at 9:22 PM Taylor Blau <me@ttaylorr.com> wrote: > > > > > > On Fri, Oct 18, 2024 at 01:52:57PM +0000, Usman Akinyemi via GitGitGadget wrote: > > > > Changes from Version 1: > > > > > > > > * In my initial commit, I mistakenly included changes from a different > > > > patch and commit. This issue has now been resolved. > > > > > > Should we treat this as a new series, then? Or is this a true reroll of > > > the previous round and should be kept together? > > Hello Taylor, > > Yeah, this should be treated as a new series different from the two below. > > - t3404: replace test with test_line_count() > > - t3404: avoid losing exit status with focus on `git show` and `git cat-file` > > Gotcha. So in the original ua/t3404-cleanup series from my tree, I > should drop the third and final patch: > > parse: replace atoi() with strtoul_ui() and strtol_i() > > ?
Hello Taylor, Yeah, exactly. Thank you. Usman Akinyemi.
> > Thanks, > Taylor