git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] ref-filter: format iteratively with lexicographic refname sorting

From
Patrick Steinhardt <ps@pks.im>
Date
Oct 21, 2024, 11:33 UTC
Message-ID
<ZxY7_mNriWFzaDQr@pks.im>
In-Reply-To
<87ttd5btjf.fsf@iotcl.com>
On Mon, Oct 21, 2024 at 01:10:44PM +0200, Toon Claes wrote:
Show 14 quoted lines
> Patrick Steinhardt <ps@pks.im> writes:
> > @@ -3258,7 +3279,6 @@ static inline int can_do_iterative_format(struct ref_filter *filter,
> >  	 */
> >  	return !(filter->reachable_from ||
> >  		 filter->unreachable_from ||
> > -		 sorting ||
> 
> Just a small nit, because we remove `sorting` from this condition, I
> suggest to also remove the following comment above it:
> 
> 	 * - sorting the filtered results
> 
> 
> Otherwise no comments from my side.
Ah, true. Will fix in v3, thanks!
Patrick
Previous: Toon ClaesNext: Patrick Steinhardt
Message 10 of 12 in “ref-filter: format iteratively with lexicographic refname sorting”
  1. ref-filter: format iteratively with lexicographic refname sortingPatrick Steinhardt, Oct 16, 2024
  2. Taylor BlauOct 16, 2024
  3. Jeff KingOct 17, 2024
  4. Patrick SteinhardtOct 17, 2024
  5. karthik nayakOct 21, 2024
  6. Taylor BlauOct 21, 2024
  7. ref-filter: format iteratively with lexicographic refname sortingPatrick Steinhardt, Oct 17, 2024
  8. Taylor BlauOct 17, 2024
  9. Toon ClaesOct 21, 2024
  10. Patrick SteinhardtOct 21, 2024
  11. ref-filter: format iteratively with lexicographic refname sortingPatrick Steinhardt, Oct 21, 2024
  12. Taylor BlauOct 21, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.