From: Patrick Steinhardt <ps@pks.im>
Date: Mon, 21 Oct 2024 11:33:50 GMT
Subject: Re: [PATCH v2] ref-filter: format iteratively with lexicographic refname sorting
Message-ID: <ZxY7_mNriWFzaDQr@pks.im>
In-Reply-To: <87ttd5btjf.fsf@iotcl.com>

On Mon, Oct 21, 2024 at 01:10:44PM +0200, Toon Claes wrote:
> Patrick Steinhardt <ps@pks.im> writes:
> > @@ -3258,7 +3279,6 @@ static inline int can_do_iterative_format(struct ref_filter *filter,
> >  	 */
> >  	return !(filter->reachable_from ||
> >  		 filter->unreachable_from ||
> > -		 sorting ||
> 
> Just a small nit, because we remove `sorting` from this condition, I
> suggest to also remove the following comment above it:
> 
> 	 * - sorting the filtered results
> 
> 
> Otherwise no comments from my side.

Ah, true. Will fix in v3, thanks!

Patrick