Re: [PATCH] ref-filter: format iteratively with lexicographic refname sorting
- From
Taylor Blau <me@ttaylorr.com>
- Date
- Oct 16, 2024, 22:11 UTC
- Message-ID
- <ZxA6I67FfPe4fV2F@nand.local>
- In-Reply-To
- <a873ed828ccae426214cc8f87610df97ff9a269e.1729055871.git.ps@pks.im>
On Wed, Oct 16, 2024 at 08:00:30AM +0200, Patrick Steinhardt wrote:
Show 15 quoted lines
> But there is one exception here where we _can_ get away with sorting > refs while streaming: ref backends sort references returned by their > iterators in lexicographic order. So if the following conditions are all > true we can do iterative streaming: > > - The caller uses at most a single name pattern. Otherwise we'd have > to sort results from multiple invocations of the iterator. > > - There must be at most a single sorting specification, as otherwise > we're not using plain lexicographic ordering. > > - The sorting specification must use the "refname". > > - The sorting specification must not be using any flags, like > case-insensitive sorting.
Perhaps a niche case, but what about ancient packed-refs files that were written before the 'sorted' capability was introduced?
Thanks, Taylor