Re: [PATCH 1/6] doc: update-ref: drop “flag”

From: Taylor Blau <me@ttaylorr.com>
Date: Oct 16, 2024, 22:09 UTC
Message-ID: <ZxA5ni7McD1c1yuf@nand.local>
In-Reply-To: <CAPig+cSuQwu4YeZ5cs-g0oAnhCf1LMS1SSywyPc_vBExh85ahw@mail.gmail.com>

On Wed, Oct 16, 2024 at 06:08:05PM -0400, Eric Sunshine wrote:

Show 12 quoted lines

> On Wed, Oct 16, 2024 at 4:46 PM Taylor Blau <me@ttaylorr.com> wrote:
> > On Tue, Oct 15, 2024 at 09:03:10PM +0200, kristofferhaugsbakk@fastmail.com wrote:
> > > -With `-d` flag, it deletes the named <ref> after verifying it
> > > +With `-d`, it deletes the named <ref> after verifying it
> > >  still contains <old-oid>.
> >
> > It looks like we may want to re-wrap this paragraph after tweaking the
> > wording on the first line.
>
> I think we typically avoid rewrapping after minor edits like this
> since rewrapping introduces unnecessary noise which makes it more
> difficult for reviewers to identify the important (actual) change.

I have done it in the past myself, since I often find the result of re-wrapping much nicer to read. But I see what you are saying, and certainly don't feel strongly.

Thanks, Taylor