Re: [PATCH v2 1/6] Documentation/git-update-ref.txt: drop “flag”
- From
karthik nayak <karthik.188@gmail.com>
- Date
- Oct 20, 2024, 11:09 UTC
- Message-ID
- <CAOLa=ZTJqcEOQm8Ns58t6DxEXYn2ws__HDRRAaAhsBkJJFLXmg@mail.gmail.com>
- In-Reply-To
- <91c1cae32098e82033f9b20ead6d1bc8e315da22.1729367469.git.code@khaugsbakk.name>
kristofferhaugsbakk@fastmail.com writes:
Show 30 quoted lines
> From: Kristoffer Haugsbakk <code@khaugsbakk.name> > > The other paragraphs on options say “With <option>,”. Let’s be uniform. > > Signed-off-by: Kristoffer Haugsbakk <code@khaugsbakk.name> > --- > > Notes (series): > v2: > • Message: tweak > • Not done: paragraph wrapping. I found something else in this > paragraph: missing “that”: “after verifying *that*”. I will fix that > in an upcoming series since there were four other missing instances of > this word and I did not want to add another patch to this series. > > Documentation/git-update-ref.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/git-update-ref.txt b/Documentation/git-update-ref.txt > index afcf33cf608..fe5967234e9 100644 > --- a/Documentation/git-update-ref.txt > +++ b/Documentation/git-update-ref.txt > @@ -55,7 +55,7 @@ for reading but not for writing (so we'll never write through a > ref symlink to some other tree, if you have copied a whole > archive by creating a symlink tree). > > -With `-d` flag, it deletes the named <ref> after verifying it > +With `-d`, it deletes the named <ref> after verifying it > still contains <old-oid>. >
So you mean it would read nicer as s/verifying/verifying that/. Which makes sense to me, I'd have preferred that this was fixed here and the others in a follow up patch like you mentioned, but that's okay!
> With `--stdin`, update-ref reads instructions from standard input and > -- > 2.46.1.641.g54e7913fcb6