Re: [PATCH 0/6] doc: update-ref: amend old material and discuss symrefs

From: Kristoffer Haugsbakk <kristofferhaugsbakk@fastmail.com>
Date: Oct 16, 2024, 21:00 UTC
Message-ID: <9b8925d3-3f2b-4396-a0b0-3b72bba5e53b@app.fastmail.com>
In-Reply-To: <ZxAoFUDmdfZ8rlLs@nand.local>

On Wed, Oct 16, 2024, at 22:54, Taylor Blau wrote:

Show 20 quoted lines

> Thanks for working on this. These changes generally looked good to me
> (although seeing smart-quotes in the commit messages was a little
> surprising ;-)).
>
> I'm making a note for the next WC report to expect a new round that
> corrects the subject line of the penultimate patch "doc: update-ref:
> discuss symbolic links".
>
> As a general note, prefixing commits with "doc: update-ref: " is a
> little strange to me. I think I might have instead written:
>
>     Documentation/git-update-ref.txt: remove safety paragraphs
>
> , and so on. I left a couple of other small notes, but I don't think any
> of them are urgent to address, though it would be nice.
>
> Thanks for working on this and improving Git's documentation.
>
> Thanks,
> Taylor

Thanks for the review overview. I’ll change the subjects/area parts in the next round.

I looked through the commit subjects for `Documentation` in the past and, seeing several different styles, landed on one of the shorter ones. According to my recollection.

-- 
Kristoffer Haugsbakk