Re: [PATCH 12/13] INSTALL: require Perl 5.26.0
- From
Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
- Date
- Oct 11, 2024, 09:38 UTC
- Message-ID
- <ZwjyHl98xRs9TDQZ@ugly>
- In-Reply-To
- <20241010235621.738239-13-sandals@crustytoothpaste.net>
On Thu, Oct 10, 2024 at 11:56:20PM +0000, brian m. carlson wrote:
>Update the INSTALL file to reflect our new dependency requirement. >
any particular reason not to squash this into the parent commit? i see how the separation makes sense for the libcurl sub-series, but that doesn't seem applicable here.
regarding the actual `use` statements, you could make them somewhat more legible by using 'v5.26' as the version number.
another aspect to consider is that the statement doesn't just specify the minimal version, but also subtly changes behavior. for example, the `use strict;` statements become redundant.
cf. https://perldoc.perl.org/functions/use#use-VERSION
lastly, it would be nice to update the build systems to reflect the version requirements. though the only pre-existing version check i found is the libcurl one in contrib/buildsystems/CMakeLists.txt.