Re: [PATCH 12/13] INSTALL: require Perl 5.26.0

From: brian m. carlson <sandals@crustytoothpaste.net>
Date: Oct 15, 2024, 22:48 UTC
Message-ID: <Zw7xNX1Tk8BbT9k_@tapette.crustytoothpaste.net>
In-Reply-To: <ZwjyHl98xRs9TDQZ@ugly>

On 2024-10-11 at 09:38:38, Oswald Buddenhagen wrote:

Show 6 quoted lines

> On Thu, Oct 10, 2024 at 11:56:20PM +0000, brian m. carlson wrote:
> > Update the INSTALL file to reflect our new dependency requirement.
> > 
> any particular reason not to squash this into the parent commit?
> i see how the separation makes sense for the libcurl sub-series, but
> that doesn't seem applicable here.

Sure, I can do that.

Show 8 quoted lines

> regarding the actual `use` statements, you could make them somewhat more
> legible by using 'v5.26' as the version number.
> 
> another aspect to consider is that the statement doesn't just specify
> the minimal version, but also subtly changes behavior. for example, the
> `use strict;` statements become redundant.
> 
> cf. https://perldoc.perl.org/functions/use#use-VERSION

Yes, I'll change that to a require v5.26 instead, since my goal isn't to change the behaviour.

> lastly, it would be nice to update the build systems to reflect the
> version requirements. though the only pre-existing version check i found
> is the libcurl one in contrib/buildsystems/CMakeLists.txt.

I don't build with cmake, so I can't speak to the requirements for it. It doesn't actually work on Unix as far as I know, and I don't run Windows at all.

-- 
brian m. carlson (they/them or he/him)
Toronto, Ontario, CA