Re: [PATCH] t0610: work around flaky test with concurrent writers

From: Patrick Steinhardt <ps@pks.im>
Date: Oct 4, 2024, 15:26 UTC
Message-ID: <ZwAJIRPUrxu5ox3w@pks.im>
In-Reply-To: <277c243f-7179-4946-99c8-b19ad5c85412@ramsayjones.plus.com>

On Fri, Oct 04, 2024 at 03:47:01PM +0100, Ramsay Jones wrote:

Show 19 quoted lines

> On 04/10/2024 13:16, Patrick Steinhardt wrote:
> [snip]
> 
> > Now the two reports are somewhat different from one another:
> > 
> >   - On Cygwin we hit timeouts because we fail to lock the "tables.list"
> >     file within 10 seconds. The renames themselves succeed even when the
> >     target file is open because Cygwin provides extensive compatibility
> >     logic to make them work even when the target file is open already.
> 
> Hmm, not so much for me! :(
> 
> > 
> >   - On MinGW we hit I/O errors on rename. While we do have some retry
> >     logic in place to make the rename work in some cases, this is
> >     seemingly not sufficient when there is this much contention around
> >     the files.
> 
> I am seeing I/O errors.

Interesting! I wonder why I don't see them. Maybe it's boiling down to timing again.

[snip]

> Can you think of anything else to try?

Not really, no. I'd be curious whether Windows 11 has the same failure mode for Cygwin, but cannot test it myself.

> I would strongly suggest skipping this test on cygwin as well as MINGW.

Yup, I definitely agree. I was operating under the assumption that Cygwin works alright. Now that we know that it doesn't we should adapt the condition from "!MINGW" to "!WINDOWS".

Patrick