Re: [PATCH v2] t0610: work around flaky test with concurrent writers

From: Jeff King <peff@peff.net>
Date: Oct 4, 2024, 22:41 UTC
Message-ID: <20241004224105.GB580885@coredump.intra.peff.net>
In-Reply-To: <f3874c7e923846e453499e89f00dd4f8862e4c40.1728055880.git.ps@pks.im>

On Fri, Oct 04, 2024 at 05:32:16PM +0200, Patrick Steinhardt wrote:

Show 6 quoted lines

> Work around the issue by disabling the test on Windows for now. While at
> it, increase the locking timeout to address reported timeouts when using
> either the address or memory sanitizer, which also tend to significantly
> extend the runtime of this test.
> 
> This should be revisited after Git v2.47 is out.

This sounds OK to me.

In general, I worry about papering over bugs with a "we'll revisit it later" note. We may forget about things or never prioritize them. And the worst-case scenario here is that we might later decide to promote reftable to the default format, forgetting that concurrency has problems on Windows.

But given that it's an area you've been actively working in, there's already been some discussion towards the real fix, and we still consider reftables somewhat experimental, I feel OK bumping it for now.

Thanks for all the digging on this (from you and from other folks).

-Peff