Re: v2.47.0-rc1 test failure on cygwin

From: Patrick Steinhardt <ps@pks.im>
Date: Oct 4, 2024, 03:59 UTC
Message-ID: <Zv9oIrKveu-JAGQM@pks.im>
In-Reply-To: <b1b5fb40-f6c2-4621-b58c-9b7c8c64cc01@ramsayjones.plus.com>

On Fri, Oct 04, 2024 at 02:02:44AM +0100, Ramsay Jones wrote:

Show 6 quoted lines

> Hi Patrick,
> 
> Just a quick heads up: t0610-reftable-basics.sh test 47 (ref transaction: many
> concurrent writers) fails on cygwin. The tail end of the debug output for this
> test looks like:
>

[snip]

Show 7 quoted lines

> 
> t0610-reftable-basics.sh passed on 'rc0', but this test (and the timeout facility)
> is new in 'rc1'. I tried simply increasing the timeout (10 fold), but that didn't
> change the result. (I didn't really expect it to - the 'reftable: transaction
> prepare: I/O error' does not look timing related!).
> 
> Again, just a heads up. (I can't look at it until tomorrow now; any ideas?)

This failure is kind of known and discussed in [1]. Just to make it explicit: this test failure doesn't really surface a regression, the reftable code already failed for concurrent writes before. I fixed that and added the test that is now flaky, as the fix itself is seemingly only sufficient on Linux and macOS.

I didn't yet have the time to look at whether I can fix it, but should finally find the time to do so today.

Patrick

[1]: <20240927040752.GA567671@coredump.intra.peff.net>