Re: [PATCH 03/10] t/lib-gitweb: test against the build version of gitweb

From: Taylor Blau <me@ttaylorr.com>
Date: Oct 14, 2024, 22:06 UTC
Message-ID: <Zw2V/Xy5niJh9dr9@nand.local>
In-Reply-To: <eda73d81139e640f4f942818f6035770b7bc9121.1728906490.git.ps@pks.im>

On Mon, Oct 14, 2024 at 02:21:18PM +0200, Patrick Steinhardt wrote:

Show 23 quoted lines

> When testing gitweb we set up the CGI script as "gitweb.perl", which is
> the source file of the build target "gitweb.cgi". This works alright as
> long as we run in-tree tests. But we're about to make out-of-tree tests
> a reality, and there things will break because "gitweb.perl" will not be
> found in the build directory.
>
> Fix this by using "gitweb.cgi" instead.
>
> Signed-off-by: Patrick Steinhardt <ps@pks.im>
> ---
>  t/lib-gitweb.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/t/lib-gitweb.sh b/t/lib-gitweb.sh
> index 1f32ca66ea5..c64c87fb87d 100644
> --- a/t/lib-gitweb.sh
> +++ b/t/lib-gitweb.sh
> @@ -49,7 +49,7 @@ EOF
>  		error "Cannot find gitweb at $GITWEB_TEST_INSTALLED."
>  		say "# Testing $SCRIPT_NAME"
>  	else # normal case, use source version of gitweb
> -		SCRIPT_NAME="$GIT_BUILD_DIR/gitweb/gitweb.perl"
> +		SCRIPT_NAME="$GIT_BUILD_DIR/gitweb/gitweb.cgi"

This one I am a bit confused above. Could the same thing not be accomplished with the '$GITWEB_TEST_INSTALLED' variable above?

If not, why not? And likewise, I believe the "source version" part of this comment would need an update.

Thanks, Taylor