Re: [PATCH 05/10] t1401: make invocation of tar(1) work with Win32-provided one

From: Taylor Blau <me@ttaylorr.com>
Date: Oct 15, 2024, 00:29 UTC
Message-ID: <Zw23WxDIeQh9FjJv@nand.local>
In-Reply-To: <CAPig+cS4X=sX84XOoNiw7jVO5Gaze-155Gcd6sO-UzyFXZ1Z3A@mail.gmail.com>

On Mon, Oct 14, 2024 at 07:23:29PM -0400, Eric Sunshine wrote:

Show 11 quoted lines

> On Mon, Oct 14, 2024 at 8:21 AM Patrick Steinhardt <ps@pks.im> wrote:
> > Windows nowadays provides a tar(1) binary in "C:\Windows\system32". This
> > version of tar(1) doesn't seem to handle the case where directory paths
> > end with a trailing forward slash. And as we do that in t1401 the result
> > is that the test fails.
> >
> > Drop the trailing slash. Other tests that use tar(1) work alright, this
> > is the only instance where it has been failing.
> > ---
>
> Missing sign-off.

Very good catch. It sounds like we will see a reroll of this series, then.

Thanks, Taylor

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.