Re: [PATCH v2 08/10] t7300: work around platform-specific behaviour with long paths on MinGW
- From
James Liu <james@jamesliu.io>
- Date
- Oct 16, 2024, 06:35 UTC
- Message-ID
- <D4X0SYYSUPWO.CFCUEN5B3MOQ@jamesliu.io>
- In-Reply-To
- <13c06a8129b13a672d3b8329db83db103607787b.1728992306.git.ps@pks.im>
On Tue Oct 15, 2024 at 10:45 PM AEDT, Patrick Steinhardt wrote:
Show 14 quoted lines
> Windows by default has a restriction in place to only allow paths up to > 260 characters. This restriction can nowadays be lifted by setting a > registry key, but is still active by default. > > In t7300 we have one test that exercises the behaviour of git-clean(1) > with such long paths. Interestingly enough, this test fails on my system > that uses Windows 10 with mingw-w64 installed via MSYS2: instead of > observing ENAMETOOLONG, we observe ENOENT. This behaviour is consistent > across multiple different environments I have tried. > > I cannot say why exactly we observe a different error here, but I would > not be surprised if this was either dependent on the Windows version, > the version of MinGW, the current working directory of Git or any kind > of combination of these.
That's very strange. I'll try it on my Windows 11 23H2 system to see if I can observe the same behaviour.
I think it's fine to just catch both cases in the test anyway.