Re: [PATCH v2 17/19] t: retire 'GIT_TEST_MULTI_PACK_INDEX_WRITE_BITMAP'

From: Taylor Blau <me@ttaylorr.com>
Date: Aug 1, 2024, 20:36 UTC
Message-ID: <Zqvx32vv8u4WDTKg@nand.local>
In-Reply-To: <20240801104647.GQ1159276@coredump.intra.peff.net>

On Thu, Aug 01, 2024 at 06:46:47AM -0400, Jeff King wrote:

Show 6 quoted lines

> ...if it is one or the other, I think it is better to test the new code.
>
> And I do think that midx bitmap code is less likely to be exercised in
> interesting ways by random parts of the test suite (versus something
> like GIT_TEST_DEFAULT_HASH, whose effects are pervasive). So I think
> this is a good tradeoff.

Thanks, I appreciate your careful reasoning here.

> Patch looks good.

Thanks also for the review :-).

Thanks, Taylor

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.