Re: [PATCH v2 03/19] midx: teach `nth_midxed_pack_int_id()` about incremental MIDXs

From: Taylor Blau <me@ttaylorr.com>
Date: Aug 1, 2024, 18:57 UTC
Message-ID: <ZqvajDLI6Rc6KXMX@nand.local>
In-Reply-To: <20240801093006.GC1159276@coredump.intra.peff.net>

On Thu, Aug 01, 2024 at 05:30:06AM -0400, Jeff King wrote:

Show 10 quoted lines

> On Wed, Jul 17, 2024 at 05:12:04PM -0400, Taylor Blau wrote:
>
> > [^1]: As a reminder, this means that the object is identified among the
> >   objects contained in all layers of the incremental MIDX chain, not any
> >   particular layer. For example, consider MIDX chain with two individual
> >   MIDXs, one with 4 objects and another with 3 objects. If the MIDX with
> >   4 objects appears earlier in the chain, then asking for pack "6" would
> >   return the second object in the MIDX with 3 objects.
>
> I think this is "object 6" in the final sentence?

Oops, yes. Thanks for spotting, this was as easy as s/pack/object on the second to last line in the paragraph quoted above.

Show 7 quoted lines

> OK, so now this function translates a global position into a local one,
> and then we get the pack id for the local midx/pos, and then turn it
> back into a global pack id.
>
> That all makes sense, but you definitely have to read carefully to make
> sure which positions/ids are global within the chain and which are local
> to a midx.

Exactly.

Thanks, Taylor