From: Taylor Blau <me@ttaylorr.com>
Date: Thu, 01 Aug 2024 20:36:47 GMT
Subject: Re: [PATCH v2 17/19] t: retire 'GIT_TEST_MULTI_PACK_INDEX_WRITE_BITMAP'
Message-ID: <Zqvx32vv8u4WDTKg@nand.local>
In-Reply-To: <20240801104647.GQ1159276@coredump.intra.peff.net>

On Thu, Aug 01, 2024 at 06:46:47AM -0400, Jeff King wrote:
> ...if it is one or the other, I think it is better to test the new code.
>
> And I do think that midx bitmap code is less likely to be exercised in
> interesting ways by random parts of the test suite (versus something
> like GIT_TEST_DEFAULT_HASH, whose effects are pervasive). So I think
> this is a good tradeoff.

Thanks, I appreciate your careful reasoning here.

> Patch looks good.

Thanks also for the review :-).

Thanks,
Taylor