git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/3] refs: do not label special refs as pseudo refs

From
Patrick Steinhardt <ps@pks.im>
Date
Apr 30, 2024, 12:33 UTC
Message-ID
<ZjDlMs3Zm1JQybAx@tanuki>
In-Reply-To
<CAOLa=ZSLx3BQa8zHyDZp5CDuQc4rgSk1LjSX=uQViWXsiv1LZQ@mail.gmail.com>
On Tue, Apr 30, 2024 at 05:07:19AM -0700, Karthik Nayak wrote:
> Jeff King <peff@peff.net> writes:
> 
> > On Tue, Apr 30, 2024 at 09:30:05AM +0200, Patrick Steinhardt wrote:
[snip]
Show 29 quoted lines
> >> > Are there any practical implications of the changes in this patch for users
> >> > running commands like "git log FETCH_HEAD" (I can't think of any off the top
> >> > of my head but it would be good to have some reassurance on that point in
> >> > the commit message)
> >>
> >> Not really, no. We have never been doing a good job at enforcing the
> >> difference between pseudo refs or normal refs anyway. Pseudo refs can be
> >> symrefs just fine, and our tooling won't complain. The only exception
> >> where I want us to become stricter is in how we enforce the syntax rules
> >> for root refs (which is handled by Peff in a separate patch series), and
> >> that we start to not treat FETCH_HEAD and MERGE_HEAD as proper refs.
> >> They should still resolve when you ask git-rev-parse(1), but when you
> >> iterate through refs they should not be surfaced as they _aren't_ refs.
> >
> > I actually would not even mind if they are surfaced when iterating with
> > --include-root-refs. But then I am a little skeptical of the purpose of
> > that feature in the first place. After all, the reason code shoves stuff
> > into .git/FOO_HEAD is precisely because we don't want other stuff
> > iterating over them, using them for reachability, and so on. That is why
> > "--all" does not include them, for example.
> >
> > But I did not follow the development of the feature, so maybe I am
> > missing some cool use case.
> >
> 
> The use case was to allow us to look at these refs when working with
> the reftable backend. Currently there is no way to do that, with the
> files backend, well you could just read the files. So mostly a debugging
> usecase.

That's true for normal root refs, only, though. The pseudorefs (current special refs) can still be surfaced even if the for-each-ref machinery doesn't surface them because by definition, they always live in the filesystem.

Patrick
Previous: Karthik NayakNext: Patrick Steinhardt
Message 10 of 93 in “Clarify pseudo-ref terminology”
  1. 0/3 Clarify pseudo-ref terminologyPatrick Steinhardt, Apr 29, 2024
  2. 1/3 refs: move `is_special_ref()`Patrick Steinhardt, Apr 29, 2024
  3. 2/3 refs: do not label special refs as pseudo refsPatrick Steinhardt, Apr 29, 2024
  4. Phillip WoodApr 29, 2024
  5. Patrick SteinhardtApr 30, 2024
  6. Phillip WoodApr 30, 2024
  7. Patrick SteinhardtApr 30, 2024
  8. Jeff KingApr 30, 2024
  9. Karthik NayakApr 30, 2024
  10. Patrick SteinhardtApr 30, 2024
  11. Patrick SteinhardtApr 30, 2024
  12. Junio C HamanoApr 29, 2024
  13. Justin ToblerApr 29, 2024
  14. Patrick SteinhardtApr 30, 2024
  15. Jean-Noël AVILAMay 9, 2024
  16. Patrick SteinhardtMay 10, 2024
  17. 3/3 refs: fix segfault in `is_pseudoref()` when ref cannot be resolvedPatrick Steinhardt, Apr 29, 2024
  18. Phillip WoodApr 29, 2024
  19. Karthik NayakApr 29, 2024
  20. Phillip WoodApr 29, 2024
  21. Karthik NayakApr 29, 2024
  22. Patrick SteinhardtApr 30, 2024
  23. 00/10 Clarify pseudo-ref terminologyPatrick Steinhardt, Apr 30, 2024
  24. 01/10 Documentation/glossary: redefine pseudorefs as special refsPatrick Steinhardt, Apr 30, 2024
  25. Karthik NayakApr 30, 2024
  26. Justin ToblerApr 30, 2024
  27. Junio C HamanoApr 30, 2024
  28. Patrick SteinhardtMay 2, 2024
  29. 02/10 Documentation/glossary: clarify limitations of pseudorefsPatrick Steinhardt, Apr 30, 2024
  30. Kristoffer HaugsbakkApr 30, 2024
  31. 03/10 Documentation/glossary: define root refs as refsPatrick Steinhardt, Apr 30, 2024
  32. Karthik NayakApr 30, 2024
  33. 04/10 refs: rename `is_pseudoref()` to `is_root_ref()`Patrick Steinhardt, Apr 30, 2024
  34. Junio C HamanoApr 30, 2024
  35. 05/10 refs: refname `is_special_ref()` to `is_pseudo_ref()`Patrick Steinhardt, Apr 30, 2024
  36. Karthik NayakApr 30, 2024
  37. 06/10 refs: classify HEAD as a root refPatrick Steinhardt, Apr 30, 2024
  38. 07/10 refs: root refs can be symbolic refsPatrick Steinhardt, Apr 30, 2024
  39. Justin ToblerApr 30, 2024
  40. Patrick SteinhardtMay 2, 2024
  41. Justin ToblerMay 3, 2024
  42. Patrick SteinhardtMay 7, 2024
  43. 08/10 refs: pseudorefs are no refsPatrick Steinhardt, Apr 30, 2024
  44. 09/10 ref-filter: properly distinuish pseudo and root refsPatrick Steinhardt, Apr 30, 2024
  45. Karthik NayakApr 30, 2024
  46. Patrick SteinhardtMay 2, 2024
  47. Karthik NayakMay 2, 2024
  48. 10/10 refs: refuse to write pseudorefsPatrick Steinhardt, Apr 30, 2024
  49. 00/10 Clarify pseudo-ref terminologyPatrick Steinhardt, May 2, 2024
  50. 01/10 Documentation/glossary: redefine pseudorefs as special refsPatrick Steinhardt, May 2, 2024
  51. 02/10 Documentation/glossary: clarify limitations of pseudorefsPatrick Steinhardt, May 2, 2024
  52. 03/10 Documentation/glossary: define root refs as refsPatrick Steinhardt, May 2, 2024
  53. 04/10 refs: rename `is_pseudoref()` to `is_root_ref()`Patrick Steinhardt, May 2, 2024
  54. 05/10 refs: refname `is_special_ref()` to `is_pseudo_ref()`Patrick Steinhardt, May 2, 2024
  55. 06/10 refs: classify HEAD as a root refPatrick Steinhardt, May 2, 2024
  56. 07/10 refs: root refs can be symbolic refsPatrick Steinhardt, May 2, 2024
  57. Jeff KingMay 3, 2024
  58. Patrick SteinhardtMay 15, 2024
  59. Patrick SteinhardtMay 15, 2024
  60. Jeff KingMay 15, 2024
  61. Patrick SteinhardtMay 15, 2024
  62. Jeff KingMay 15, 2024
  63. Patrick SteinhardtMay 15, 2024
  64. Jeff KingMay 15, 2024
  65. 08/10 refs: pseudorefs are no refsPatrick Steinhardt, May 2, 2024
  66. 09/10 ref-filter: properly distinuish pseudo and root refsPatrick Steinhardt, May 2, 2024
  67. 10/10 refs: refuse to write pseudorefsPatrick Steinhardt, May 2, 2024
  68. 00/10 Clarify pseudo-ref terminologyPatrick Steinhardt, May 10, 2024
  69. 01/10 Documentation/glossary: redefine pseudorefs as special refsPatrick Steinhardt, May 10, 2024
  70. 02/10 Documentation/glossary: clarify limitations of pseudorefsPatrick Steinhardt, May 10, 2024
  71. 03/10 Documentation/glossary: define root refs as refsPatrick Steinhardt, May 10, 2024
  72. 04/10 refs: rename `is_pseudoref()` to `is_root_ref()`Patrick Steinhardt, May 10, 2024
  73. 05/10 refs: refname `is_special_ref()` to `is_pseudo_ref()`Patrick Steinhardt, May 10, 2024
  74. 06/10 refs: root refs can be symbolic refsPatrick Steinhardt, May 10, 2024
  75. 07/10 refs: classify HEAD as a root refPatrick Steinhardt, May 10, 2024
  76. 08/10 refs: pseudorefs are no refsPatrick Steinhardt, May 10, 2024
  77. 09/10 ref-filter: properly distinuish pseudo and root refsPatrick Steinhardt, May 10, 2024
  78. 10/10 refs: refuse to write pseudorefsPatrick Steinhardt, May 10, 2024
  79. Junio C HamanoMay 10, 2024
  80. 00/10 Clarify pseudo-ref terminologyPatrick Steinhardt, May 15, 2024
  81. 01/10 Documentation/glossary: redefine pseudorefs as special refsPatrick Steinhardt, May 15, 2024
  82. 02/10 Documentation/glossary: clarify limitations of pseudorefsPatrick Steinhardt, May 15, 2024
  83. 03/10 Documentation/glossary: define root refs as refsPatrick Steinhardt, May 15, 2024
  84. 04/10 refs: rename `is_pseudoref()` to `is_root_ref()`Patrick Steinhardt, May 15, 2024
  85. 05/10 refs: rename `is_special_ref()` to `is_pseudo_ref()`Patrick Steinhardt, May 15, 2024
  86. 06/10 refs: do not check ref existence in `is_root_ref()`Patrick Steinhardt, May 15, 2024
  87. Justin ToblerMay 15, 2024
  88. Patrick SteinhardtMay 16, 2024
  89. 07/10 refs: classify HEAD as a root refPatrick Steinhardt, May 15, 2024
  90. Justin ToblerMay 15, 2024
  91. 08/10 refs: pseudorefs are no refsPatrick Steinhardt, May 15, 2024
  92. 09/10 ref-filter: properly distinuish pseudo and root refsPatrick Steinhardt, May 15, 2024
  93. 10/10 refs: refuse to write pseudorefsPatrick Steinhardt, May 15, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.