Re: [PATCH v5 0/8] fast-import: tighten parsing of paths
- From
Patrick Steinhardt <ps@pks.im>
- Date
- Apr 15, 2024, 07:06 UTC
- Message-ID
- <ZhzR3QiuzfQ8LYgy@tanuki>
- In-Reply-To
- <cover.1713056559.git.thalia@archibald.dev>
On Sun, Apr 14, 2024 at 01:11:32AM +0000, Thalia Archibald wrote:
Show 13 quoted lines
> > fast-import has subtle differences in how it parses file paths between each > > occurrence of <path> in the grammar. Many errors are suppressed or not checked, > > which could lead to silent data corruption. A particularly bad case is when a > > front-end sent escapes that Git doesn't recognize (e.g., hex escapes are not > > supported), it would be treated as literal bytes instead of a quoted string. > > > > Bring path parsing into line with the documented behavior and improve > > documentation to fill in missing details. > > Changes since v4: > * Refine C comments and parameter name. > > Thalia
I had another cursory read of this patch series that relied on the range diffs for most of the part. In any way, this version looks good to me. Thanks!
Patrick