Re: [PATCH v2 1/8] fast-import: tighten path unquoting

From: Thalia Archibald <thalia@archibald.dev>
Date: Apr 10, 2024, 09:14 UTC
Message-ID: <6C467327-0DB1-4E1F-8CB5-23DE45271348@archibald.dev>
In-Reply-To: <CAPx1GvfUs-dR_RbqnBT3YhDJPMB7b=+fzyow8qjJgJQnJwg0Pw@mail.gmail.com>

On Apr 10, 2024, at 01:51, Chris Torek <chris.torek@gmail.com> wrote:

Show 5 quoted lines

> On Wed, Apr 10, 2024 at 1:47 AM Thalia Archibald <thalia@archibald.dev> wrote:
>> strchrnul does what I want here and I’ve replaced it with that.
> 
> `strchrnul` is a GNU extension (found on a lot of systems, but not
> part of C90 or C99).

I can’t speak to Git standards, but it seems broadly used in Git, including three times already in fast-import:

$ rg --count-matches --sort=path strchrnul add-patch.c:1 advice.c:1 apply.c:2 archive.c:1 attr.c:1 builtin/am.c:1 builtin/fast-export.c:5 builtin/fast-import.c:4 builtin/stash.c:1 cache-tree.c:2 commit.c:5 compat/mingw.c:1 compat/terminal.c:1 config.c:1 diff.c:1 fmt-merge-msg.c:2 fsck.c:2 git-compat-util.h:3 git.c:1 gpg-interface.c:8 graph.c:1 help.c:1 http.c:2 ident.c:2 log-tree.c:1 mailmap.c:1 match-trees.c:1 notes.c:1 object-file.c:2 parse-options.c:2 path.c:1 pretty.c:2 ref-filter.c:5 refs/debug.c:1 remote-curl.c:1 remote.c:1 run-command.c:1 scalar.c:1 sequencer.c:5 strbuf.c:1 trailer.c:1 transport-helper.c:1 utf8.c:1 ws.c:1 wt-status.c:1

Thalia