Re: [PATCH v2 02/13] Makefile: only set some BASIC_CFLAGS when RUNTIME_PREFIX is set

From: Patrick Steinhardt <ps@pks.im>
Date: Apr 14, 2025, 07:54 UTC
Message-ID: <Z_y_REMmW95_5IcI@pks.im>
In-Reply-To: <8df541634aedbba40d8b0fa57dbf9cb0e495f11b.1743859985.git.ramsay@ramsayjones.plus.com>

On Sun, Apr 06, 2025 at 08:38:28PM +0100, Ramsay Jones wrote:

Show 12 quoted lines

> Several build variables only have any meaning when the RUNTIME_PREFIX
> variable has been set. In particular, the following build variables are
> otherwise ignored:
> 
>     HAVE_BSD_KERN_PROC_SYSCTL
>     PROCFS_EXECUTABLE_PATH
>     HAVE_NS_GET_EXECUTABLE_PATH
>     HAVE_ZOS_GET_EXECUTABLE_PATH
>     HAVE_WPGMPTR
> 
> Make setting BASIC_CFLAGS, for each of these variables, conditional on
> the RUNTIME_PREFIX being defined.

Makes sense. We already handle all of these conditionally in Meson, so there's nothing else we need to do there.

Patrick

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.