From: Patrick Steinhardt <ps@pks.im>
Date: Mon, 14 Apr 2025 07:54:44 GMT
Subject: Re: [PATCH v2 02/13] Makefile: only set some BASIC_CFLAGS when RUNTIME_PREFIX is set
Message-ID: <Z_y_REMmW95_5IcI@pks.im>
In-Reply-To: <8df541634aedbba40d8b0fa57dbf9cb0e495f11b.1743859985.git.ramsay@ramsayjones.plus.com>

On Sun, Apr 06, 2025 at 08:38:28PM +0100, Ramsay Jones wrote:
> Several build variables only have any meaning when the RUNTIME_PREFIX
> variable has been set. In particular, the following build variables are
> otherwise ignored:
> 
>     HAVE_BSD_KERN_PROC_SYSCTL
>     PROCFS_EXECUTABLE_PATH
>     HAVE_NS_GET_EXECUTABLE_PATH
>     HAVE_ZOS_GET_EXECUTABLE_PATH
>     HAVE_WPGMPTR
> 
> Make setting BASIC_CFLAGS, for each of these variables, conditional on
> the RUNTIME_PREFIX being defined.

Makes sense. We already handle all of these conditionally in Meson, so
there's nothing else we need to do there.

Patrick