Re: [PATCH] t3706: Add test for wildcard vs literal pathspec

From: brian m. carlson <sandals@crustytoothpaste.net>
Date: Apr 15, 2025, 22:32 UTC
Message-ID: <Z_7ekhsBzXK6LKuV@tapette.crustytoothpaste.net>
In-Reply-To: <20250412174051.780148-1-jayatheerthkulkarni2005@gmail.com>

On 2025-04-12 at 17:40:51, K Jayatheerth wrote:

> +test_expect_success 'recreate files to test add behavior' '
> +    mkdir testdir &&
> +    >testdir/f\* &&
> +    >testdir/f\*\* &&

I just want to point out that creating files with asterisks may not be possible on Windows due to limitations in the file system. I'm not a Windows expert, so unfortunately I can't provide more details than that, but you may end up needing to add a prerequisite here to skip this on our Windows platforms if necessary. Hopefully CI and a suitable search can help you figure it out.

> +test_done
> \ No newline at end of file

We do want to keep newlines at the end of a file. POSIX mandates one on text files and some systems are less tolerant of missing newlines than others. Usually Linux and the BSDs handle this just fine, but some proprietary Unix systems, which unfortunately we don't have CI for, tend to be the ones that are less happy about this.

I haven't given this a full review, since others have done that instead, but just pointed out one or two things that got my attention.

-- 
brian m. carlson (they/them)
Toronto, Ontario, CA