Re: [PATCH 0/1] add: fix pathspec handling when literal filenames match wildcard

From: JAYATHEERTH K <jayatheerthkulkarni2005@gmail.com>
Date: Apr 12, 2025, 17:34 UTC
Message-ID: <CA+rGoLdDVYKUz02dhgPy50nhG-K-cjyLUySFtunGL1+f=AD7wg@mail.gmail.com>
In-Reply-To: <9EB38EEC-97EA-4F8D-BCC6-883771203755@gmail.com>

On Sat, Apr 12, 2025 at 9:15 PM Lucas Seiki Oshiro <lucasseikioshiro@gmail.com> wrote:

>
> Hi!

Hey Lucas!

Show 6 quoted lines

>
> The original bug repot included some simple steps to reproduce
> the bug. Since it is a corner case that wasn't covered by our
> current test suite, it would be nice if you created a new
> test case covering that.
>

Yeah!! I was testing them with options like f** and f\*\* for specific file additions for commits I have framed a test frame in t-3706 which is the add and pathspec coverage as far as I can see.

> PS: Since this is a single patch, you could sent this without
> a cover letter, putting your comments after the scissors mark
> (---).

Ahh I do that because if I receive feedback it forms like a good summary in the beginning. But sure, I think the *scissors mark* method sounds good too!!

Will send the patch inline to this email I think you've worked with Tests in your microproject Drop some feedback. Those will be very helpful!!

Thank you, -Jayatheerth