git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] t3706: Add test for wildcard vs literal pathspec

From
Lucas Seiki Oshiro <lucasseikioshiro@gmail.com>
Date
Apr 19, 2025, 17:43 UTC
Message-ID
<9200B571-071D-4BBF-B5E3-886B5CCFB89A@gmail.com>
In-Reply-To
<CA+rGoLes1u3LZiStmDPmh4iiUNzNY43KyYNdLadQU+cy1TCc4A@mail.gmail.com>
Hi!
> reset_git_repo &&

I couldn't reproduce this as I don't have that function here. Is it a command that you defined locally?

> I get issues with these test cases,
> Specially at git ls-tree -r --name-only HEAD > actual_files
> 
> For some reason the test_cmp doesn't get resolved

You can check the output of those commands by calling your test script with the `-v` flag.

If `test_cmp a b` is false, you can check why by placing a temporary `diff a b` for displaying what changed, of course running with a `-v`.

> Is it a bad way to do? or is there a better way?

I don't see any problem based on that code snippet (except for the reset_git_repo that is not defined), but it looks like that there are other changes compared to the code you sent in the patch, so I don't have enough context.

Previous: JAYATHEERTH KNext: JAYATHEERTH K
Message 14 of 19 in “add: fix pathspec handling when literal filenames match wildcard”
  1. 0/1 add: fix pathspec handling when literal filenames match wildcardK Jayatheerth, Apr 12, 2025
  2. 1/1 add: fix handling literal filenames and wildcardsK Jayatheerth, Apr 12, 2025
  3. t3706: Add test for wildcard vs literal pathspecK Jayatheerth, Apr 12, 2025
  4. Lucas Seiki OshiroApr 14, 2025
  5. JAYATHEERTH KApr 14, 2025
  6. Junio C HamanoApr 14, 2025
  7. brian m. carlsonApr 15, 2025
  8. JAYATHEERTH KApr 16, 2025
  9. Junio C HamanoApr 16, 2025
  10. JAYATHEERTH KApr 16, 2025
  11. Lucas Seiki OshiroApr 16, 2025
  12. Junio C HamanoApr 16, 2025
  13. JAYATHEERTH KApr 19, 2025
  14. Lucas Seiki OshiroApr 19, 2025
  15. JAYATHEERTH KApr 22, 2025
  16. JAYATHEERTH KApr 16, 2025
  17. JAYATHEERTH KApr 16, 2025
  18. Lucas Seiki OshiroApr 12, 2025
  19. JAYATHEERTH KApr 12, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.