Re: [PATCH 04/12] setup: start tracking ref storage format when

From: Patrick Steinhardt <ps@pks.im>
Date: Dec 28, 2023, 08:56 UTC
Message-ID: <ZY04MuIQtuxNFwIw@tanuki>
In-Reply-To: <CAOLa=ZQLLqj=78dJN0y51EFf3_XsHnTBYNjkB0cAAGf3dXJ9KA@mail.gmail.com>

On Fri, Dec 22, 2023 at 05:09:37AM -0800, Karthik Nayak wrote:

Show 33 quoted lines

> Patrick Steinhardt <ps@pks.im> writes:
> > diff --git a/refs.c b/refs.c
> > index e87c85897d..d289a5e175 100644
> > --- a/refs.c
> > +++ b/refs.c
> > @@ -2045,12 +2045,12 @@ static struct ref_store *ref_store_init(struct repository *repo,
> >  					const char *gitdir,
> >  					unsigned int flags)
> >  {
> > -	int format = REF_STORAGE_FORMAT_FILES;
> > -	const struct ref_storage_be *be = find_ref_storage_backend(format);
> > +	const struct ref_storage_be *be;
> >  	struct ref_store *refs;
> >
> > +	be = find_ref_storage_backend(repo->ref_storage_format);
> >  	if (!be)
> > -		BUG("reference backend %s is unknown", ref_storage_format_to_name(format));
> > +		BUG("reference backend is unknown");
> >
> >  	refs = be->init(repo, gitdir, flags);
> >  	return refs;
> > diff --git a/refs.h b/refs.h
> > index c6571bcf6c..944a67ac1b 100644
> > --- a/refs.h
> > +++ b/refs.h
> > @@ -11,6 +11,7 @@ struct string_list;
> >  struct string_list_item;
> >  struct worktree;
> >
> > +int default_ref_storage_format(void);
> >
> 
> Is this used/defined somewhere?

No, it's a leftover from a previous iteration. Will drop.

Patrick