Re: [PATCH 01/12] t: introduce DEFAULT_REPO_FORMAT prereq

From: Karthik Nayak <karthik.188@gmail.com>
Date: Dec 22, 2023, 11:41 UTC
Message-ID: <CAOLa=ZSY-FBUMOx9SHkJqf7XteQC=hVoYxo73q=E1wL3QOBYtA@mail.gmail.com>
In-Reply-To: <239ca38efdbe3195e6319be4423b17d2b42e0b9f.1703067989.git.ps@pks.im>

Patrick Steinhardt <ps@pks.im> writes:

Show 6 quoted lines

> A limited number of tests require repositories to have the default
> repository format or otherwise they would fail to run, e.g. because they
> fail to detect the correct hash function. While the hash function is the
> only extension right now that creates problems like this, we are about
> to add a second extensions for the ref format.
>

Nit: s/extensions/extension

Show 5 quoted lines

> -test_expect_success SHA1 'git branch -m q q2 without config should succeed' '
> +test_expect_success DEFAULT_REPO_FORMAT 'git branch -m q q2 without config should succeed' '
>  	git branch -m q q2 &&
>  	git branch -m q2 q
>  '

My only concern is whether we'll end up blindly adding DEFAULT_REPO_FORMAT for tests where only SHA1 is a prereq or only where the new format extension is a prereq.