Re: [PATCH 01/12] t: introduce DEFAULT_REPO_FORMAT prereq

From: Patrick Steinhardt <ps@pks.im>
Date: Dec 28, 2023, 08:55 UTC
Message-ID: <ZY04G_p1W_4EDeSX@tanuki>
In-Reply-To: <CAOLa=ZSY-FBUMOx9SHkJqf7XteQC=hVoYxo73q=E1wL3QOBYtA@mail.gmail.com>

On Fri, Dec 22, 2023 at 03:41:10AM -0800, Karthik Nayak wrote:

> Patrick Steinhardt <ps@pks.im> writes:

[snip]

Show 9 quoted lines

> > -test_expect_success SHA1 'git branch -m q q2 without config should succeed' '
> > +test_expect_success DEFAULT_REPO_FORMAT 'git branch -m q q2 without config should succeed' '
> >  	git branch -m q q2 &&
> >  	git branch -m q2 q
> >  '
> 
> My only concern is whether we'll end up blindly adding
> DEFAULT_REPO_FORMAT for tests where only SHA1 is a prereq or only where
> the new format extension is a prereq.

Yeah, this is of course a possibility with this new prereq. I don't really know what to do about it though, and think that it does serve a sensible purpose. So... dunno.

Patrick