Re: [PATCH 01/24] pack-objects: free packing_data in more places

From: Taylor Blau <me@ttaylorr.com>
Date: Nov 30, 2023, 19:08 UTC
Message-ID: <ZWjdu4h96CSKU/Tr@nand.local>
In-Reply-To: <ZWhhcv25B5nUNoyu@tanuki>

On Thu, Nov 30, 2023 at 11:18:26AM +0100, Patrick Steinhardt wrote:

Show 13 quoted lines

> > diff --git a/pack-objects.c b/pack-objects.c
> > index f403ca6986..1c7bedcc94 100644
> > --- a/pack-objects.c
> > +++ b/pack-objects.c
> > @@ -151,6 +151,21 @@ void prepare_packing_data(struct repository *r, struct packing_data *pdata)
> >  	init_recursive_mutex(&pdata->odb_lock);
> >  }
> >
> > +void free_packing_data(struct packing_data *pdata)
>
> Nit: shouldn't this rather be called `clear_packing_data`? `free` to me
> indicates that the data structure itself will be free'd, as well, which
> is not the case.

Thanks, that's a good suggestion. I've made the changes locally and will include it in the subsequent round(s) ;-).

Thanks, Taylor

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.