Re: [PATCH 02/24] pack-bitmap-write: deep-clear the `bb_commit` slab
- From
Jeff King <peff@peff.net>
- Date
- Dec 12, 2023, 07:04 UTC
- Message-ID
- <20231212070406.GA1117953@coredump.intra.peff.net>
- In-Reply-To
- <6f5ff96998946f3f49da56fd05c096b949521339.1701198172.git.me@ttaylorr.com>
On Tue, Nov 28, 2023 at 02:07:59PM -0500, Taylor Blau wrote:
Show 6 quoted lines
> +static void clear_bb_commit(struct bb_commit *commit)
> +{
> + free(commit->reverse_edges);
> + bitmap_free(commit->commit_mask);
> + bitmap_free(commit->bitmap);
> +}I think these bitmaps may sometimes be NULL. But double-checking bitmap_free(), it sensibly is noop when passed NULL. So this look good to me.
-Peff