Re: git diagnose with invalid CLI argument does not report error

From: Bagas Sanjaya <bagasdotme@gmail.com>
Date: Oct 26, 2023, 11:10 UTC
Message-ID: <ZTpJFUdE2U6pbV--@debian.me>
In-Reply-To: <849b6ee2-99f3-4aaa-835f-44d3e13befc3@gmail.com>

On Thu, Oct 26, 2023 at 07:49:58AM +1100, Sheik wrote:

Show 17 quoted lines

> Hi Maintainers,
> 
> 
> Running git diagnose with an invalid CLI argument in a valid Git directory
> does not report error. Expected behaviour would be that it reports an error.
> 
> #Example shell commands which should have reported an error but continues to
> succeed
> 
> cd $ToAGitDirectory
> 
> git diagnose mod
> 
> git diagnose mode
> 
> git diagnose mode=all
>

I can reproduce this only when the invalid parameter is a normal word:

``` $ git diagnose huh ```

But the command errors out on invalid flag:

``` $ git diagnose -m ```

Cc:'ing people who recently worked on builtin/diagnose.c for help.

Thanks.

-- 
An old man doll... just what I always wanted! - Clara