Re: git diagnose with invalid CLI argument does not report error

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Oct 26, 2023, 22:11 UTC
Message-ID: <CAPig+cSsB-2xxF7uQRU2h219+0-9++M_woLX3vNwiq1Uj1SiQQ@mail.gmail.com>
In-Reply-To: <ZTpJFUdE2U6pbV--@debian.me>

On Thu, Oct 26, 2023 at 7:10 AM Bagas Sanjaya <bagasdotme@gmail.com> wrote:

Show 23 quoted lines

> On Thu, Oct 26, 2023 at 07:49:58AM +1100, Sheik wrote:
> > Hi Maintainers,
> >
> > Running git diagnose with an invalid CLI argument in a valid Git directory
> > does not report error. Expected behaviour would be that it reports an error.
> >
> > #Example shell commands which should have reported an error but continues to
> > succeed
> >
> > cd $ToAGitDirectory
> > git diagnose mod
> > git diagnose mode
> > git diagnose mode=all
>
> I can reproduce this only when the invalid parameter is a normal word:
> ```
> $ git diagnose huh
> ```
> But the command errors out on invalid flag:
> ```
> $ git diagnose -m
> ```
> Cc:'ing people who recently worked on builtin/diagnose.c for help.

A patch by Emily to fix this has been submitted[v4].

[v4]: https://lore.kernel.org/git/20231026182231.3369370-3-nasamuffin@google.com/