threads / discuss / 60430

git diagnose with invalid CLI argument does not report error

Subject: git diagnose with invalid CLI argument does not report error

## tl;dr

5 messages between Oct 25, 2023 and Oct 26, 2023.

replies: 4people: 4as markdown or json

Sheik· Oct 25, 2023, 20:49 UTC · lore

Hi Maintainers,

Running git diagnose with an invalid CLI argument in a valid Git directory does not report error. Expected behaviour would be that it reports an error.

#Example shell commands which should have reported an error but continues to succeed

cd $ToAGitDirectory

git diagnose mod

git diagnose mode

git diagnose mode=all

Thanks

Sheik

[System Info] git version: git version 2.42.0 cpu: x86_64 no commit associated with this build sizeof-long: 8 sizeof-size_t: 8 shell-path: /bin/sh uname: Linux 6.5.0-2-amd64 #1 SMP PREEMPT_DYNAMIC Debian 6.5.6-1 (2023-10-07) x86_64 compiler info: gnuc: 13.2 libc info: glibc: 2.37 $SHELL (typically, interactive shell): /bin/bash

[Enabled Hooks]

Bagas Sanjaya· Oct 26, 2023, 11:10 UTC · re: Sheik · lore

Re: git diagnose with invalid CLI argument does not report error

On Thu, Oct 26, 2023 at 07:49:58AM +1100, Sheik wrote:

Show 17 quoted lines

> Hi Maintainers,
> 
> 
> Running git diagnose with an invalid CLI argument in a valid Git directory
> does not report error. Expected behaviour would be that it reports an error.
> 
> #Example shell commands which should have reported an error but continues to
> succeed
> 
> cd $ToAGitDirectory
> 
> git diagnose mod
> 
> git diagnose mode
> 
> git diagnose mode=all
>

I can reproduce this only when the invalid parameter is a normal word:

``` $ git diagnose huh ```

But the command errors out on invalid flag:

``` $ git diagnose -m ```

Cc:'ing people who recently worked on builtin/diagnose.c for help.

Thanks.

-- 
An old man doll... just what I always wanted! - Clara

Eric Sunshine· Oct 26, 2023, 22:11 UTC · re: Bagas Sanjaya · lore

Re: git diagnose with invalid CLI argument does not report error

On Thu, Oct 26, 2023 at 7:10 AM Bagas Sanjaya <bagasdotme@gmail.com> wrote:

Show 23 quoted lines

> On Thu, Oct 26, 2023 at 07:49:58AM +1100, Sheik wrote:
> > Hi Maintainers,
> >
> > Running git diagnose with an invalid CLI argument in a valid Git directory
> > does not report error. Expected behaviour would be that it reports an error.
> >
> > #Example shell commands which should have reported an error but continues to
> > succeed
> >
> > cd $ToAGitDirectory
> > git diagnose mod
> > git diagnose mode
> > git diagnose mode=all
>
> I can reproduce this only when the invalid parameter is a normal word:
> ```
> $ git diagnose huh
> ```
> But the command errors out on invalid flag:
> ```
> $ git diagnose -m
> ```
> Cc:'ing people who recently worked on builtin/diagnose.c for help.

A patch by Emily to fix this has been submitted[v4].

[v4]: https://lore.kernel.org/git/20231026182231.3369370-3-nasamuffin@google.com/

Emily Shaffer· Oct 26, 2023, 22:41 UTC · re: Eric Sunshine · lore

Re: git diagnose with invalid CLI argument does not report error

To be clear, that patch was for git-bugreport and doesn't cover git-diagnose. I assume the fix ends up being pretty similar though.

On Thu, Oct 26, 2023 at 3:12 PM Eric Sunshine <sunshine@sunshineco.com> wrote:

Show 30 quoted lines

>
> On Thu, Oct 26, 2023 at 7:10 AM Bagas Sanjaya <bagasdotme@gmail.com> wrote:
> > On Thu, Oct 26, 2023 at 07:49:58AM +1100, Sheik wrote:
> > > Hi Maintainers,
> > >
> > > Running git diagnose with an invalid CLI argument in a valid Git directory
> > > does not report error. Expected behaviour would be that it reports an error.
> > >
> > > #Example shell commands which should have reported an error but continues to
> > > succeed
> > >
> > > cd $ToAGitDirectory
> > > git diagnose mod
> > > git diagnose mode
> > > git diagnose mode=all
> >
> > I can reproduce this only when the invalid parameter is a normal word:
> > ```
> > $ git diagnose huh
> > ```
> > But the command errors out on invalid flag:
> > ```
> > $ git diagnose -m
> > ```
> > Cc:'ing people who recently worked on builtin/diagnose.c for help.
>
> A patch by Emily to fix this has been submitted[v4].
>
> [v4]: https://lore.kernel.org/git/20231026182231.3369370-3-nasamuffin@google.com/
>

Eric Sunshine· Oct 26, 2023, 22:43 UTC · re: Emily Shaffer · lore

Re: git diagnose with invalid CLI argument does not report error

On Thu, Oct 26, 2023 at 6:41 PM Emily Shaffer <nasamuffin@google.com> wrote:

Show 13 quoted lines

> On Thu, Oct 26, 2023 at 3:12 PM Eric Sunshine <sunshine@sunshineco.com> wrote:
> > On Thu, Oct 26, 2023 at 7:10 AM Bagas Sanjaya <bagasdotme@gmail.com> wrote:
> > > On Thu, Oct 26, 2023 at 07:49:58AM +1100, Sheik wrote:
> > > > Running git diagnose with an invalid CLI argument in a valid Git directory
> > > > does not report error. Expected behaviour would be that it reports an error.
> > >
> > > I can reproduce this only when the invalid parameter is a normal word:
> > > Cc:'ing people who recently worked on builtin/diagnose.c for help.
> >
> > A patch by Emily to fix this has been submitted[v4].
>
> To be clear, that patch was for git-bugreport and doesn't cover
> git-diagnose. I assume the fix ends up being pretty similar though.

My bad.